Add AnyQuotes support for unified quote handling similar to mini.ai nvim #22263
+1,025
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new AnyQuotes text object to handle text surrounded by single quotes ('), double quotes ("), or back quotes (`) seamlessly. The following changes are included:
- Added AnyQuotes to the Object enum to represent the new feature.
- Registered AnyQuotes as an action in the actions! macro and register function to ensure proper integration with Vim actions like ci, ca, di, and da.
- Extended Object::range to check for surrounding single, double, or back quotes sequentially.
- Updated methods like is_multiline and always_expands_both_ways to ensure consistent behavior with other text objects.
- Added support in surrounding_markers to evaluate any of the quote types when AnyQuotes is invoked.
- This enhancement provides users with a flexible and unified way to interact with text objects enclosed by different types of quotes.
This commit adds comprehensive tests for the new AnyQuotes text object, ensuring proper functionality and robustness. The following tests were included:
Basic Operations: Verify ciq, caq, diq, daq, viq, and vaq commands for single quotes ('), double quotes ("), and backticks (`).
Edge Cases: Test nested quotes (e.g., ' " " '), mixed quotes, and quotes with escape characters (e.g., 'It's escaped'`).
Multiline Scenarios: Validate behavior for multiline quotes across single, double, and backtick variants.
Visual Mode: Ensure proper visual selection inside and around quotes.
These tests provide full coverage for the AnyQuotes object, ensuring it behaves consistently across various scenarios and edge cases.
|
We require contributors to sign our Contributor License Agreement, and we don't have @oca159 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
maxdeviant
changed the title
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
oca159
commented
Dec 19, 2024
| "t": "vim::Tag", | ||
| "s": "vim::Sentence", | ||
| "p": "vim::Paragraph", | ||
| "'": "vim::Quotes", | ||
| "`": "vim::BackQuotes", | ||
| "\"": "vim::DoubleQuotes", | ||
| "q": "vim::AnyQuotes", |
There was a problem hiding this comment.
Important code change, all the other changes in this file is just formatting
1 task
oca159
changed the title
maxdeviant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit 1:
I tested it locally and it works!
IMPORTANT:
Feedback and suggestions for improvement are greatly appreciated!
This commit introduces a new AnyQuotes text object to handle text surrounded by single quotes ('), double quotes ("), or back quotes (`) seamlessly. The following changes are included: