Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: Add scroll_beyond_last_line setting #11155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evan-liu
Copy link

@evan-liu evan-liu commented Apr 29, 2024

Add scroll_beyond_last_line setting with 3 options:

  • one_page: The default (current) behaviour of scrolling one more page beyond the last line.
SCR-20240429-sxry
  • off: No scrolling beyond the last line.
SCR-20240429-syhv
  • vertical_scroll_margin: Scroll beyond the last line by the same number of lines as vertical_scroll_margin. Matches the behaviour of keyboard scrolling.
SCR-20240429-sypc

Release Notes:

  • Added scroll_beyond_last_line setting (#4962).

Copy link

cla-bot bot commented Apr 29, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @evan-liu on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@evan-liu
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 29, 2024
Copy link

cla-bot bot commented Apr 29, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title Editor: Add scroll_beyond_last_line setting editor: Add scroll_beyond_last_line setting Apr 29, 2024
@mrnugget mrnugget requested a review from as-cii May 3, 2024 09:31
@mikayla-maki mikayla-maki self-assigned this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants