editor: Support walking through overlapping diagnostics #11139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into how to implement #4901, noticed that the current
Goto next/previous diagnostic
behaved a bit weirdly. That is, when there are multiple errors that have overlapping ranges, only the first one can be chosen to be active by thego_to_diagnostic_impl
.Previous behavior:
Screen.Recording.2024-04-28.at.21.34.29.mov
Doesn't go through all the diagnostics, and going backwards and forwards doesn't show the same diagnostic always.
New behavior:
go_to_diagnostic_after.mov
Should always go through the diagnostics in a consistent manner.
Release Notes: