Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpi4 #50

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Rpi4 #50

wants to merge 1 commit into from

Conversation

WiktorG351
Copy link
Contributor

No description provided.

Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably target develop branch and split .yml files correctly so we can use it like this:

kas-container build meta-zarhus/kas/common.yml:meta-zarhus/kas/rpi4.yml

kas/common-rpi4.yml Outdated Show resolved Hide resolved
kas/common-rpi4.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 4 yaml files? We only should need 1, rpi.yml.

Then we can use it like:

SHELL=/bin/bash KAS_MACHINE=raspberrypi4 kas-container build meta-zarhus/kas/common.yml:meta-zarhus/kas/debug.yml:meta-zarhus/kas/rpi.yml

Comment on lines +4 to +5
includes:
- kas/common.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
includes:
- kas/common.yml

kas/debug-rpi4.yml Outdated Show resolved Hide resolved
local_conf_header:
rpi-config: |
WKS_FILE = "sdimage-raspberrypi.wks"
MACHINE = "raspberrypi4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MACHINE = "raspberrypi4"

Then we could just use KAS_MACHINE=raspberrypi4.
Not only that but you are duplicating it in prod-rpi4 with machine: raspberrypi4

@WiktorG351 WiktorG351 changed the base branch from main to develop January 22, 2025 13:18
@WiktorG351
Copy link
Contributor Author

@m-iwanicki i believe i adressed this with the rebase and additional changes, could you look at it again?

@m-iwanicki
Copy link
Contributor

@WiktorG351 you should probably:

  • only leave rpi4.yml
  • rename to rpi.yml
  • remove MACHINE variable - we should use KAS_MACHINE from cmdline when building, that way we can easily change target to raspberrypi3
  • don't include common.yml in yaml file (to be consistent with other yml configs)


repos:
meta-raspberrypi:
url: https://github.com/agherzan/meta-raspberrypi.git
Copy link
Contributor

@m-iwanicki m-iwanicki Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it official repo/mirror? OpenEmbedded index points to:

git://git.yoctoproject.org/meta-raspberrypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants