🐛 🔧 fix Zappa.create_handler_venv win32 case wherestderror_result is None #1353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
Zappa.create_handler_venv
, so that when the result frompip_process.communicate()
returnsNone
for stderr, an unrelated exception is NOT raised, andzappa.create_handler_venv
proceeds as expected.Currently, the code assumes a str value is returned, but on
win32
systems, it appears thatNone
may be returned.GitHub Issues
#1342