Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical backup secret #2051

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Logical backup secret #2051

merged 7 commits into from
Jan 4, 2024

Conversation

stgrace
Copy link
Contributor

@stgrace stgrace commented Sep 19, 2022

See #2050

@robertlandrum
Copy link

The other implementation is "probably" better. Mine is definitely simpler. I'm not sure which warrants inclusion in the next release, but can say I've deployed mine to our non-prod environments.

@FxKu FxKu added this to the 2.0 milestone Dec 14, 2022
@KlavsKlavsen
Copy link

Whats holding this back? or have 2 who can approve just not reviewed it yet?

@ashish1099
Copy link

Any update, we are waiting on this one for long

@KlavsKlavsen
Copy link

@yajo @nihaldivyam I see you both approved this.. and yet the ZAPPR status says its "pending 2 approvals - 0/2 given" ?

@ashish1099
Copy link

@yajo @nihaldivyam thank you for approving, any update on when this can be merged. ?

@yajo
Copy link
Contributor

yajo commented Apr 11, 2023

I have no authority in this project, no idea. I see this one has conflicts though, so even maintainers won't be able to merge.

@stgrace stgrace requested a review from hughcapet as a code owner April 11, 2023 11:07
@stgrace
Copy link
Contributor Author

stgrace commented Apr 11, 2023

@yajo should be solved now

@FxKu
Copy link
Member

FxKu commented Apr 18, 2023

@stgrace thanks for providing this feature. I will have a look. You have to fix your unit test, too? Only +1 from project maintainers count for zappr btw.

@jonathon2nd
Copy link

Looking forward to this being done 😄
Right now managing the cronjobs manually, but every so often the operator wants to update them and places invalid config, because I do not set configLogicalBackup

@nihaldivyam
Copy link

@stgrace Eagerly waiting for this to get merged !!

@KlavsKlavsen
Copy link

@FxKu thank you for adding this to a milestone - but when will it be merged? its a "small thing" - and its really annoying we have to implement our until this works properly :(

@jiuker
Copy link

jiuker commented Jun 2, 2023

@KlavsKlavsen we need this too.

@drivebyer
Copy link
Contributor

drivebyer commented Jun 2, 2023

@idanovinda @FxKu Eagerly waiting for this to get merged too !

@stgrace
Copy link
Contributor Author

stgrace commented Jun 3, 2023

Hi everyone,
First of all sorry for the late response, I've been busy.
I've fixed the unit tests, but the e2e tests are failing for the label testing, which is not related to my PR, so not sure why that is failing and if I can fix it.

======================================================================
FAIL: test_node_affinity (test_e2e.EndToEndTestCase)
Add label to a node and update postgres cluster spec to deploy only on a node with that label

@FxKu

@ashish1099
Copy link

@FxKu can you please look in the above issues

@szechp
Copy link

szechp commented Aug 2, 2023

it would be nice if this got merged, no one wants their s3 credentials in plain text :)

@Yingrjimsch
Copy link

Eagerly waiting for this to get merged!

@FxKu
Copy link
Member

FxKu commented Jan 3, 2024

👍

1 similar comment
@idanovinda
Copy link
Member

👍

@FxKu FxKu merged commit bbba15f into zalando:master Jan 4, 2024
2 of 3 checks passed
@FxKu
Copy link
Member

FxKu commented Jan 4, 2024

Thanks @stgrace for your contribution and sorry it took us so long too merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.