Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 1.18.2 #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for 1.18.2 #87

wants to merge 1 commit into from

Conversation

MCMDEV
Copy link

@MCMDEV MCMDEV commented Mar 20, 2022

Added support for 1.18.2
Just added new method names for setting and getting an NBTCompound on an ItemStack

@synrg synrg mentioned this pull request Apr 4, 2022
Open
@OoLunar
Copy link

OoLunar commented Apr 4, 2022

Tested and working fine in production

synrg
synrg approved these changes Apr 8, 2022
View reviewed changes
Copy link

@synrg synrg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sane, and in zDevelopers/ImageOnMap#255 a user has reportedly used the PR to successfully make ImageOnMap work on 1.18.2, so this looks good to go. Anything else holding up someone with write approving the change?

oolivero45
oolivero45 approved these changes May 6, 2022
View reviewed changes
Copy link

@oolivero45 oolivero45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compiled a build from this PR and can confirm that it works, and that it resolves zDevelopers/ImageOnMap#255.

Adding my voice to the others calling for this to be merged.

@oolivero45 oolivero45 mentioned this pull request May 6, 2022
Open
FlorianCassayre
FlorianCassayre approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@FlorianCassayre FlorianCassayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me as well. I'm not active on this project anymore, however given the amount of attention this and other similar issues have brought, I think we should fix it. @AmauryCarrade

@eyeb0l eyeb0l mentioned this pull request Jun 15, 2022
Open
@StanByes
Copy link

StanByes commented Aug 9, 2022

Any date to merge this Pull Request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synrg synrg synrg approved these changes

@FlorianCassayre FlorianCassayre FlorianCassayre approved these changes

@oolivero45 oolivero45 oolivero45 approved these changes

@RWolfyo RWolfyo RWolfyo approved these changes

@OoLunar OoLunar OoLunar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MCMDEV @OoLunar @StanByes @synrg @FlorianCassayre @oolivero45 @RWolfyo