Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change player clients & deobfuscate params with NewPipeExtractor #1774

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

gechoto
Copy link
Contributor

@gechoto gechoto commented Dec 24, 2024

Should fix #1748

Changes:

  • Use WEB_REMIX client for logged in player requests
  • Use NewPipeExtractor to deobfuscate signature and throttling parameter
  • Send login only for WEB_REMIX client (IOS client doesn't support it anymore)
  • Update clients
  • Workaround until Issue#1686 YouTube cookie set to null by logout. #1694 is done

currently waiting for TeamNewPipe/NewPipeExtractor#1252

… logged in player requests + don't send login for IOS client
Copy link

gitguardian bot commented Dec 24, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14305798 Triggered Google API Key d4f9aad innertube/src/main/java/com/zionhuang/innertube/models/YouTubeClient.kt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gechoto gechoto marked this pull request as draft December 24, 2024 02:31
@gechoto gechoto changed the title Deobfuscate params with NewPipeExtractor Switch to WEB_REMIX client for logged-in player & deobfuscate params with NewPipeExtractor Dec 24, 2024
@gechoto gechoto changed the title Switch to WEB_REMIX client for logged-in player & deobfuscate params with NewPipeExtractor Change player clients & deobfuscate params with NewPipeExtractor Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to play songs in the app
1 participant