Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue improvements #1175

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Queue improvements #1175

wants to merge 3 commits into from

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Dec 19, 2023

I messed up the whole thing in the first pull request, sorry.
This PR fixes the queue list display to show the currently playing song at the top of the list, which is very useful for large queues. I've also added a way to bring up the bottom menu when you long press on a queue item.

Short spotlight:
https://github.com/z-huang/InnerTune/assets/110673332/a99a4981-ce0e-417c-ae58-e00da24bac61

#1067
#1074

@nvllz nvllz changed the title added a context menu inside queue list, fixed queue position to show … Queue improvements Dec 19, 2023
@nvllz
Copy link
Contributor Author

nvllz commented Jan 4, 2024

Just added an option to lock queue order, which can be used to prevent changing song order. Also fixed #1111 bug in queue and playlist song lists (which appears to be a Compose bug) with this modified code.

6ee6d389-143b-4a9a-b6ef-ec79d06cdd8e.mp4

Also, the padlock and shuffle icons in the bottom bar of the queue list view are more visible with #1173.

@netrunner-exe
Copy link
Contributor

Hi @nvllz! You made some really useful and needed improvements and fixed bugs that were annoying me a bit, especially with the SwipeToDismiss, great job! I'm looking forward to these changes getting into the branch. I would like to ask you, perhaps you can bring back the track switching by swiping on the album cover. The previous implementation was a bit buggy and was removed, but it’s really missing. Thank you!

@nvllz
Copy link
Contributor Author

nvllz commented Jan 5, 2024

Hi @netrunner-exe. Thanks for the kind words, it's not great yet I guess, but I tried my best. I may look into this album cover swiping in the future, but I can't promise anything yet.

@nvllz
Copy link
Contributor Author

nvllz commented Jan 5, 2024

I edited the queue song menu handling so it doesn't have 'Start Radio' icon, which was referring to currently playing song instead of selected one. I would prefer to use SongMenu-like instance here, but don't know how to easily get <Song> from database. I can only pass mediaMetadata from Queue.kt, so getting item from db with this data might change the way we can handle it.
If you, @z-huang have any idea how I could get this <Song> (so I could create a menu with SongListItem( song = song, badges = {}, trailingContent = {[...], which would not only look better but also give other options to make "play next", "add to library", heart icon in this menu), I could quickly make this menu look much better.

The most recent state of this menu looks like this:
4bbb63fd-0468-4bcf-966d-8671813c0d9e

@netrunner-exe
Copy link
Contributor

Hi @netrunner-exe. Thanks for the kind words, it's not great yet I guess, but I tried my best. I may look into this album cover swiping in the future, but I can't promise anything yet.

@nvllz, I compiled FOSS build from your branch today. I'll move on to using it daily and test it in general, but the already solved swipe bug makes me very happy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants