README: cmake build: added line to set include directory to yse #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +81,7 @@ find_package(easy_profiler REQUIRED) | |||
|
|
|||
| add_executable(app_for_profiling ${SOURCES}) | |||
|
|
|||
| target_include_directories(app_for_profiling $<TARGET_PROPERTY:easy_profiler,INTERFACE_INCLUDE_DIRECTORIES>) | |||
There was a problem hiding this comment.
@uykusuz this is redundant and unnecessary, as this is already done automatically by the PUBLIC keyword used here:
easy_profiler/easy_profiler_core/CMakeLists.txt
Lines 175 to 178 in c352f34
which will automatically include the path to every user targets that are linking easy_profiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the generated config file for easy_profiler we can use the target property for the include directory to add it to the executable in question.