New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[media] Move calls to GetPlayerStateName() #4679

Open

osagie98 wants to merge 1 commit into youtube:main from osagie98:move-getplayerstate

Contributor

osagie98 commented Jan 10, 2025

b/376316272


          [media] Move calls to GetPlayerStateName()

cecfec7

b/376316272

osagie98 requested a review from xiaomings

January 10, 2025 00:02

osagie98 mentioned this pull request

[media] Create SbPlayerState utility function #4668

Merged

Contributor Author

osagie98 commented Jan 10, 2025

If we follow this path, we may log in if (!player_bridge_) that the function is called when player_bridge_ is nullptr, as the current log of the state will be replaced by the one in the very beginning of the function. We may also turn it into a LOG(WARNING).

Not sure I understood 100%, I have two logs, one WARNING for a null player bridge, and the other is INFO. Did you want a single WARNING log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet