Allow WebAudio FIFO size to match callback buffer if it is very large #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow WebAudio FIFO size to match callback buffer if it is very large The Web Audio FIFO is over-allocated to allow for growing if there are buffer xruns. However, on some Android devices there is a very large callback buffer which will fail a CHECK. Just match the callback buffer size in this case, to avoid crashing. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293168 (cherry picked from commit 01cb952243ee9efca53b66f50d3026aeb5443049)
|
The message and trailer should follow the format like this (cc @dahlstrom-g ): |
updated, thanks! |
borongc
approved these changes
Jan 11, 2025
andrewsavage1
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/388556893
Allow WebAudio FIFO size to match callback buffer if it is very large
The Web Audio FIFO is over-allocated to allow for growing if there are buffer xruns. However, on some Android devices there is a very large callback buffer which will fail a CHECK. Just match the callback buffer size in this case, to avoid crashing.
This change is backported from m123+.
(cherry picked from commit 01cb952243ee9efca53b66f50d3026aeb5443049)
Bug: 324797343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293168