[android] Exclude demuxer memory limit when low-end-device-mode is enabled #4663
Conversation
…abled - The demuxer memory limits cause rebuffering in 4k playbacks, resulting in it restarts with a lower resolution. - Removed the demuxer memory limits so that Cobalt can play 4k playbacks smoothly with low-end-device-mode. b/388291268
| @@ -17,12 +17,14 @@ size_t SelectLimit(size_t default_limit, | |||
| if (!base::SysInfo::IsLowEndDeviceOrPartialLowEndModeEnabled()) { | |||
| return default_limit; | |||
| } | |||
| #if !BUILDFLAG(USE_STARBOARD_MEDIA) | |||
There was a problem hiding this comment.
I am going to address this properly in b/322027866.
There was a problem hiding this comment.
Will this be a separate PR, or you want to address this in this PR?
There was a problem hiding this comment.
I am going to upload a separate PR, which will address the issue on both ATV and Linux/Evergreen.
There was a problem hiding this comment.
Just to clarify, as the memory limit will be determined by demuxer_memory_limit_starboard.cc, it doesn't matter if the low-end-device-mode is enabled or not.
I'll wait for this separate PR merged, and then re-enable low-end-device-mode.
There was a problem hiding this comment.
PR created #4674, the memory limit is now determined by Starboard without taking the low end device mode into account.
Note that in future we may still have a way for low end device to specify a reduced Demuxer memory limit, and it should be a decision under Starboard (currently supported on Android TV via RRO).
b/388291268