Set up Chrobalt build acceleration with RBE. #4604
Conversation
briantting
changed the title
briantting
force-pushed
the
main
branch
2 times, most recently
from
a320f77 to
dd5de54
Compare
briantting
force-pushed
the
main
branch
4 times, most recently
from
7985666 to
8ae2da3
Compare
Set up Chrobalt build acceleration with RBE making it the default accelerator for both developers and the CI system. b/384982606
| @@ -261,7 +261,7 @@ vars = { | |||
| # Fetch configuration files required for the 'use_remoteexec' gn arg | |||
| 'download_remoteexec_cfg': False, | |||
| # RBE instance to use for running remote builds | |||
| 'rbe_instance': Str('projects/rbe-chrome-untrusted/instances/default_instance'), | |||
| 'rbe_instance': Str('projects/cobalt-actions-prod/instances/default_instance'), | |||
There was a problem hiding this comment.
Can't this be specified in the .gclient file instead of us needing to change the DEPS file? Though I don't know if there's a good way to easily do this for all devs
There was a problem hiding this comment.
It should be able to be specified in .gclient much like how download_remoteexec_cfg is when we do gclient config --name=src https://github.com/${{ github.repository }} --custom-var=download_remoteexec_cfg=True, but I wasn't sure we wanted to ever "risk" using rbe-chrome-untrusted.
Also secondly, it's a dumb question but how do you pass "/" chars in key=value command line arg. `--custom-var=rbe_instance=projects/cobalt-actions-prod/instances/default_instance' throws errors. I've tried using quotes and escape chars
build/toolchain/rbe.gni
Outdated
There was a problem hiding this comment.
Maybe there's a way we can set these variables for builds, but it would rely on gn.py—if someone runs gn gen locally without arguments do we care if they end up using the chromium reclient server vs ours?
There was a problem hiding this comment.
I rather not risk it.
-
they won't be able to because the default files will not exist since we aren't running CIPD to download them / we won't require people to have chromium CIPD access
-
if they did manage it would be slower since the Chromium's instances cache wont be updated with our compile tasks constantly like our instance's cache would be.
Remove fetching of RBE cfg files with CIPD. Instead rely on local cfg files which use public docker images rather than private ones. Taken from Chromium's trunk. b/384982606
b/384982606