Move starboard media headers to prevent circular dependency #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
approved these changes
Dec 17, 2024
xiaomings
reviewed
Dec 22, 2024
| @@ -371,6 +371,15 @@ source_set("base") { | |||
| "webvtt_util.h", | |||
| ] | |||
|
|
|||
| if (use_starboard_media) { | |||
There was a problem hiding this comment.
This may not be the best way to resolve this circular dependency. The original dependency from //media/base to //media/starboard was introduced in https://github.com/youtube/cobalt/pull/4348/files#diff-ec1e4ec37e5873a7e4de1c82ef9858dd14c5e4c82d786879d8aa65b3e909df98R67. The code adds decoder_buffer_allocator_ to MediaClient, which is supposed to be mostly an interface.
The concrete implementation (i.e. decoder_buffer_allocator_) should be added to a derived class of MediaClient, e.g. RenderMediaClient. In that case the circular dependency will be removed, and Starboard code can stay in //media/starboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/380940036
Separate headers and implementation to prevent unnecessary circular dependency.