Add Python 3.12 support #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfouque
commented
Jan 9, 2024
| @@ -25,7 +29,8 @@ deps = | |||
| deps = | |||
| # sphinx | |||
| Sphinx==4.2.0 | |||
| django-dbdiff | |||
| ; django-dbdiff | |||
| git+https://github.com/pfouque/django-dbdiff.git@fix312#egg=django-dbdiff | |||
There was a problem hiding this comment.
@marianoeramirez you're now hooked to my fork of django-dbdiff ... :/
There was a problem hiding this comment.
Yes, but we will have to wait a long time before them review and integrate the PR. Once that happen I will update the project.
There was a problem hiding this comment.
Ok, I'm fine with that, I wanted to be sure you noticed! ;)
In the meantime, I started a branch to remove this dependency,
and use load_fixtures/dump_fixtures instead + a backport of the assertNoDiff statement
It was promising, and only the command was missing tests.
Do you want me to publish the draft?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding the last version of Python 3.12 to the test matrix and package classifier
Extracted from #283, this PR depends on yourlabs/django-dbdiff#21