2.9.12.67+pgjdbc-ng #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unrecognized option: --add-modules Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit.
|
That will work for switching the default driver, I think it would probably be better to keep this as an option and use the official driver as a default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luminus-framework/luminus-template#281
Is all that was needed for this change remove the incompatible parts of PostgreSQL driver?
In my own limited experience, I haven't noticed much of a difference between using the +postgres driver and the PGJDBC-NG changes mentioned in @yogthos post https://yogthos.net/posts/2016-11-05-LuminusPostgresNotifications.html
If there's anything else to get this change up to completion, let me know, thanks.