-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress indicator #43
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit d25c213): https://ymath-beta--pr43-progress-indicator-fhkmu8db.web.app (expires Sun, 12 Dec 2021 23:42:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
@sophiazhu16 Known problems with this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Edit: just realized I reviewed it twice. Oops
@sophiazhu16 It is probably not ideal to approve a pull request when it is incomplete ;) As Product Manager, is there anything you would like to add to the checklist for this project? (first comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to make the progress label change automatically? Or maybe just have some buttons instead of the dropdown menu - when I'm at the bottom of the page, marking the lesson as finished should take 1 click at most, preferably 0.
I think setting standards for auto-detecting completion would be hard, maybe if they scroll all the way down? |
I have done most of what this PR is for, I will now work on making those progress selections a bit smoother |
…h.io into progress-indicator
A tracker for the user's progress across courses. Closes #17.
Current problems are:
Roadmap before this is ready for review