Rework #14
Merged
Rework #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
machour
commented
Apr 26, 2019
machour
commented
- Changed namespace
- Removed deprecated classes
- Removed non amqp drivers (see Create additional packages for drivers #13)
- Fixed all tests but the "retry" test
machour
commented
Apr 26, 2019
|
|
||
| return $this->queue->handleError(ExecEvent::before($id, $job, $ttr, $attempt, $error)); | ||
| return $this->queue->handleError(ExecEvent::error($id, $job, $ttr, $attempt, $error)); |
There was a problem hiding this comment.
This is wrong, error() takes an Event as first and only parameter.
@zhuravljov something went horribly wrong with ErrorEvent removal, and that leads to "retry" tests failing.
I'm having a little trouble debugging this as this is all happening in child processes.. could you have a look please? 🙏
| @@ -60,17 +60,6 @@ services: | |||
| depends_on: *php_depends_on | |||
There was a problem hiding this comment.
Do we still need docker setups? Travis seems to be handling what's left of the drivers everything pretty well.
|
@samdark could you do a quick review and merge this if it looks good enough? Keeping this PR up to date is going to be a nightmare with all the namespace changes currently taking place. |
samdark
requested changes
Apr 29, 2019
| @@ -60,17 +60,6 @@ services: | |||
| depends_on: *php_depends_on | |||
|
Looks good enough to me. @machour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.