Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create additional packages for drivers #13

Open
machour opened this issue Apr 17, 2019 · 15 comments
Open

Create additional packages for drivers #13

machour opened this issue Apr 17, 2019 · 15 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@machour
Copy link
Member

machour commented Apr 17, 2019

https://forum.yiiframework.com/t/additional-packages-for-specific-drivers-storages/125718/2

  • amqp_interop
  • beanstalk
  • db
  • file
  • gearman
  • redis
  • sqs
  • sync
@samdark
Copy link
Member

samdark commented Apr 17, 2019

I wonder if we need non-amqp_interop drivers...

@samdark
Copy link
Member

samdark commented Apr 17, 2019

@zhuravljov what do you think?

@samdark
Copy link
Member

samdark commented Apr 18, 2019

What's currently covered by amqp_interop:

  • beanstalk
  • sqs
  • redis
  • gearman
  • file
  • db (via doctrine so not a good fit for Yii)

That leaves us with:

  • amqp_interop
  • sync (could be part of the library itself)
  • db

@machour
Copy link
Member Author

machour commented Apr 18, 2019

Agreed, sync belongs in yiisoft/yii-queue.
Having db & amqp-interop as drivers sounds good for a start.

@samdark
Copy link
Member

samdark commented Apr 18, 2019

https://github.com/yiisoft/yii-queue-interop

I don't think we need to create DB driver at this point. We can add it later.

This was referenced Apr 25, 2019
@samdark samdark added status:ready for adoption Feel free to implement this issue. and removed status:under discussion labels Apr 30, 2019
@larryli
Copy link

larryli commented May 6, 2019

How about the debug & gii modules of yiisoft/yii-queue?

Does these also separate into different packages such as yiisoft/yii-debug-queue and yiisoft/yii-gii-queue?

@machour
Copy link
Member Author

machour commented May 6, 2019

Same things goes for db-redis for example which currently embeds:

  • debug
  • rbac
  • i18n
  • gii

@samdark how would we handle these & the case mentioned by @larryli ?
Ideally we need to split those in order to have minimalistic requirements in composer.json, but I'm afraid we'll end up with a zillion packages to maintain.

@rob006
Copy link

rob006 commented May 6, 2019

db (via doctrine so not a good fit for Yii)

I'm not sure how redis driver is different than db in this case - Yii has its own redis extension with own connection - reusing it should be preferred over whatever amqp_interop uses.

@machour
Copy link
Member Author

machour commented Jun 11, 2019

We also need to take care of porting the stomp driver

@aphraoh
Copy link

aphraoh commented Mar 22, 2024

https://github.com/yiisoft/yii-queue-interop

I don't think we need to create DB driver at this point. We can add it later.

Hi @samdark , do you not think we should actually do DB driver first, reason I say so is barrier to entry, most people have LAMP or WAMP, so without installing anything else they should be use yiisoft/queue. What do you think?

@samdark
Copy link
Member

samdark commented Mar 22, 2024

Could be done, yes. yiisoft/db is released so no obstacles. Do you want to handle it?

@aphraoh
Copy link

aphraoh commented Mar 24, 2024

Could be done, yes. yiisoft/db is released so no obstacles. Do you want to handle it?

DbAdapter.zip

Done!
Would like to add it in the same folder that SynchronousAdapter.php is. Confirm this is OK?
NOTE: This will be my first check into Github, so a bit nervous!
Will then raise a few issue to fix the TODO in the file.

@samdark
Copy link
Member

samdark commented Mar 24, 2024

No, that should be separate repository.

@aphraoh
Copy link

aphraoh commented Mar 24, 2024

No, that should be separate repository.

Alexander, that is fine but like I said I have never checked anything into Github, maybe you can help me by creating an empty repository, maybe we can call it yiisoft/queue-db, and I can take it from there!?...

@vjik
Copy link
Member

vjik commented Mar 25, 2024

@samdark samdark closed this as completed Mar 26, 2024
@samdark samdark reopened this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

No branches or pull requests

6 participants