Use a copy of the server list when restarting #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the original server list is used, it is cleared during the step of removing filetype buffers, so no servers are actually restarted, as the `lspservers` list is empty by the time the `for` loop is reached.
|
thx, |
I don't know, I tried removing it and it doesn't seem to have broken anything, but I haven't tried to exhaustively chase down code paths and make sure it doesn't cause problems elsewhere. Probably safer just to leave it for now. |
|
> do you think the 'copy()' in `RemoveFile()` func still required?
I don't know, I tried removing it and it doesn't seem to have broken anything, but I haven't tried to exhaustively chase down code paths and make sure it doesn't cause problems elsewhere. Probably safer just to leave it for now.
yes, per your PR, i was reading it, then found that 'copy()' in `RemoveFile()` was weird, i donot understand why it was there or any useful.. 🤷
// maybe it was a copy/paste or refactor code, then move the 'copy()' to wrong place.
…--
shane.xb.qian
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original server list is used, it is cleared during the step of removing filetype buffers, so no servers are actually restarted, as the
lspserverslist is empty by the time theforloop is reached.Fixes #378