fix: hover popup-filter, remove redundant code #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original few lines of code are redundant. Just return false and let vim handle the other keys. The redundant code disabled mouse scrolling, and the popup will be closed automatically after some seconds (I don't know why it is closed automatically)
Song-Tianxiang
changed the title
yegappan
reviewed
Jan 16, 2024
| # For any other key, close the hover window | ||
| hoverWin->popup_close() | ||
| endif | ||
|
|
There was a problem hiding this comment.
Pressing Escape should close the hover popup window. With the above change, the escape key will not close the hover window. An explicit check for Esc key should be added to close the popup window.
The default way uses <C-c> to close the popup window, the escape key is added to also close the popup window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original few lines of code are redundant.
Just return false and let vim handle the other keys. The redundant code disabled mouse scrolling, and the popup will be closed automatically after some seconds (I don't know why it is closed automatically)