fix: inlay hints maybe emit too early #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shane.xb.qian <[email protected]>
|
Based on the comments in #395, it looks like this doesn't really fix that problem. |
yegappan
reviewed
Sep 20, 2023
|
Based on the comments in #395, it looks like this doesn't really fix that problem.
no, if no this, regardingless project size, it would be high possibility failed,
seems gopls really was a bit delay (not really ready) to response,
besides this is a refine to inlay hints code anyway,
so this PR is required.
…--
shane.xb.qian
|
// thanks to the patch on channel
|
thanks to that patch on channel, i reduced the value of delay a bit, should be a balanced value now, wish so. |
|
or let it be, since that channel patch perhaps was better or good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #395