Skip to content

Commit

Permalink
Always run the PR builder step even if others are cancelled (nv-morph…
Browse files Browse the repository at this point in the history
…eus#1736)

- This forces the `pr-builder` step to always be run. Since this is a required step in order to merge a PR, we want to make sure it is always run.
- This is needed since we skip some steps in CI by default which causes the pr-builder step to be skipped as well.

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Tad ZeMicheal (https://github.com/tzemicheal)

URL: nv-morpheus#1736
  • Loading branch information
mdemoret-nv authored Jun 14, 2024
1 parent fc3e45c commit 0b284b5
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,6 @@ permissions:

jobs:

pr-builder:
needs:
- prepare
- checks
- ci_pipe
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]

prepare:
# Executes the get-pr-info action to determine if the PR has the skip-ci label, if the action fails we assume the
# PR does not have the label
Expand Down Expand Up @@ -99,3 +91,13 @@ jobs:
test_container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-test-240524
secrets:
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}

pr-builder:
# Always run this step even if others are skipped or cancelled
if: '!cancelled()'
needs:
- prepare
- checks
- ci_pipe
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]

0 comments on commit 0b284b5

Please sign in to comment.