Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring #43

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Small refactoring #43

merged 3 commits into from
Oct 11, 2023

Conversation

noname0443
Copy link
Collaborator

@noname0443 noname0443 commented Oct 6, 2023 •
edited
Loading

  • Changed 'Disable' constant to improve readability
  • Structs optimized
  • Removed duplication in queryRowWithTimeout and queryRows
  • Other small changes

Used golangci-lint to detect alignment mistakes in structures: https://golangci-lint.run/usage/install/
Use it with config.yaml:

linters:
  enable:
    - maligned

Run it: golangci-lint run ./... --config ./config.yaml

@noname0443 noname0443 marked this pull request as ready for review October 6, 2023 10:37
teem0n
teem0n approved these changes Oct 11, 2023
View reviewed changes
internal/util/util.go Outdated
@@ -37,24 +37,24 @@ func TouchFile(fname string) error {
_, err := os.Stat(fname)
if os.IsNotExist(err) {
err := os.WriteFile(fname, []byte(""), 0644)
//file, err := os.Create(fname)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove commented code

@teem0n teem0n merged commit c6874ee into yandex:master Oct 11, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teem0n teem0n teem0n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noname0443 @teem0n