Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiline results #35 #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for multiline results #35 #37

wants to merge 1 commit into from
+109 −1

Conversation

Eoksni
Copy link

@Eoksni Eoksni commented Jun 26, 2019 •
edited

Closes #35.

Example usage:

/**
 * @example
 *   subtract(1, 2)
 *   // => {
 *   // =>   normal: -1,
 *   // =>   reverse: 1
 *   // => }
 */

 function subtract(x, y) {
  return {
    normal: x - y,
    reverse: y - x
  };
}

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.963% when pulling 2b57ab9 on Eoksni:develop into ccd6cdb on yamadapc:master.

yamadapc
yamadapc reviewed Feb 10, 2021
View reviewed changes
lib/comment-parser.js
@@ -91,7 +91,7 @@ exports.parseExamples = function commentParser$parseExamples(parsedComments) {
var currentCaption;

for(var i = 0, len = parsedComments.length; i < len; i++) {
if(parsedComments[i].type === 'code') {
if(parsedComments[i].type === 'code' && parsedComments[i].string) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand. It was already supported then, but missing some error handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamadapc yamadapc yamadapc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Multiline support
3 participants
@Eoksni @coveralls @yamadapc