Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double-header and simple-header #113

Merged
merged 7 commits into from
May 27, 2024
Merged

Add double-header and simple-header #113

merged 7 commits into from
May 27, 2024

Conversation

illionillion
Copy link
Member

Closes #68

Description

image

Current behavior (updates)

Please describe the current behavior that you are modifying

New behavior

Please describe the behavior or changes this PR adds

Is this a breaking change (Yes/No):

Additional Information

@vercel Vercel
Copy link

vercel bot commented May 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yamada-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 11:37am

taroj1205
taroj1205 reviewed May 26, 2024
View reviewed changes
Copy link
Member

@taroj1205 taroj1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます！
レスポンシブ対応は難しかったでしょうか？
出来なそうであれば、後でPR出します。
ホバーした際、underlineを表示しないように出来ませんか？

contents/application-ui/headers/double-header/index.tsx Outdated Show resolved Hide resolved
contents/application-ui/headers/double-header/metadata.json Outdated Show resolved Hide resolved
contents/application-ui/headers/double-header/index.tsx Outdated Show resolved Hide resolved
contents/application-ui/headers/double-header/index.tsx Show resolved Hide resolved
contents/application-ui/headers/simple-header/metadata.json Outdated Show resolved Hide resolved
@illionillion
Copy link
Member Author

PRありがとうございます！ レスポンシブ対応は難しかったでしょうか？ 出来なそうであれば、後でPR出します。 ホバーした際、underlineを表示しないように出来ませんか？

レスポンシブはどのように対応すれば良いですか？
ナビゲーション部分を折り返すのか、メディアクエリ等駆使して任意のウィンドウサイズで表示を変えるのか

taroj1205
taroj1205 approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@taroj1205 taroj1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illionillion illionillion merged commit 2fc7f90 into main May 27, 2024
2 checks passed
@illionillion illionillion deleted the feat/headers-components branch May 27, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taroj1205 taroj1205 taroj1205 approved these changes

@hirotomoyamada hirotomoyamada Awaiting requested review from hirotomoyamada

Assignees

@hirotomoyamada hirotomoyamada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Headers
3 participants
@illionillion @taroj1205 @hirotomoyamada