Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you select a suggestion from the dropdown (with keyboard control), the highlight will return to the top (without scrolling either) and to return to the point you were before you need to scroll endlessly again. This PR fixes the behavior by keeping highlight in the same spot (also, did you notice that the code to highlight the next option never worked? At least in select mode, didn't try anything else).
A real case scenario: A user scroll down with arrows and by mistake selects the wrong value, now he has to scroll down again to were it was, not very user friendly!
And here is the video (the commit there miss the
true
inhighlightOption
that I added later to fix highlighting when dropdown is filtered, but is the same for that matter)1.mov