Prevent dropdown from showing twice #1414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In select mode the dropdown will show twice when clicking inside input and then using "Tab" key to get out
|
I can see the issue still happens even with your code changes: 1414.mp4I click inside, see the dropdown. and hit I assume you are referring to this behavior |
|
Mmmh interesting. Let me check later today, I will update you |
|
You are right and I'm sorry. I was working on many fixes and things rapidly got screwed up. I inserted a note here because this PR is dependent by that patch too. To be more precise this PR #1414 helps fixing this behavior the first time you click on the input/tag (or after you removed it), the subsequent time is #1410 (comment) that is taking care of preventing the behavior. Hope everything is clear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In select mode the dropdown will show twice when clicking inside input and then using "Tab" key to get out. Separated "Enter" and "Tab" cases and added conditional to remove blur if
mode === select1.mov