4.13.3

yairEO · Jul 13, 2022 · 7b8e208 · 7b8e208
1 parent 4060b04
commit 7b8e208
Show file tree

Hide file tree

Showing 8 changed files with 31 additions and 31 deletions.
diff --git a/dist/jQuery.tagify.min.js b/dist/jQuery.tagify.min.js
diff --git a/dist/react.tagify.js b/dist/react.tagify.js
diff --git a/dist/tagify.css b/dist/tagify.css
diff --git a/dist/tagify.esm.js b/dist/tagify.esm.js
@@ -1,5 +1,5 @@
 /**
- * Tagify (v 4.13.2) - tags input component
+ * Tagify (v 4.13.3) - tags input component
  * By Yair Even-Or
  * https://github.com/yairEO/tagify
  * Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -382,7 +382,7 @@ var _dropdown = {
     // 2. dropdown is disabled
     // 3. loader is showing (controlled outside of this code)
 
-    if (noWhitelist && !allowNewTags && !_s.templates.dropdownItemNoMatch || _s.dropdown.enable === false || this.state.isLoading) return;
+    if (noWhitelist && !allowNewTags && !_s.templates.dropdownItemNoMatch || _s.dropdown.enable === false || this.state.isLoading || this.settings.readonly) return;
     clearTimeout(this.dropdownHide__bindEventsTimeout); // if no value was supplied, show all the "whitelist" items in the dropdown
     // @type [Array] listItems
     // TODO: add a Setting to control items' sort order for "listItems"
@@ -1877,17 +1877,19 @@ var events = {
       // node isn't in the DOM anynmore because it has been replaced.
 
       if (!this.DOM.scope.contains(editableElm)) return;
-
       var _s = this.settings,
           tagElm = editableElm.closest('.' + _s.classNames.tag),
           textValue = this.input.normalize.call(this, editableElm),
-          originalData = this.tagData(tagElm).__originalData,
+          tagData = this.tagData(tagElm),
+          originalData = tagData.__originalData,
           // pre-edit data
-      hasChanged = this.editTagChangeDetected(this.tagData(tagElm)),
+      hasChanged = this.editTagChangeDetected(tagData),
           isValid = this.validateTag({
-        [_s.tagTextProp]: textValue
+        [_s.tagTextProp]: textValue,
+        __tagId: tagData.__tagId
       }),
-          hasMaxTags,
+          // "__tagId" is needed so validation will skip current tag when checking for dups
+      hasMaxTags,
           newTagData;
 
       if (!textValue) {
@@ -2952,10 +2954,8 @@ Tagify.prototype = {
   },
 
   setContentEditable(state) {
-    if (!this.settings.readonly && this.settings.userInput) {
-      this.DOM.input.contentEditable = state;
-      this.DOM.input.tabIndex = !!state ? 0 : -1;
-    }
+    this.DOM.input.contentEditable = state;
+    this.DOM.input.tabIndex = !!state ? 0 : -1;
   },
 
   setDisabled(isDisabled) {

diff --git a/dist/tagify.js b/dist/tagify.js
@@ -1,5 +1,5 @@
 /**
- * Tagify (v 4.13.2) - tags input component
+ * Tagify (v 4.13.3) - tags input component
  * By Yair Even-Or
  * https://github.com/yairEO/tagify
  * Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -388,7 +388,7 @@
       // 2. dropdown is disabled
       // 3. loader is showing (controlled outside of this code)
 
-      if (noWhitelist && !allowNewTags && !_s.templates.dropdownItemNoMatch || _s.dropdown.enable === false || this.state.isLoading) return;
+      if (noWhitelist && !allowNewTags && !_s.templates.dropdownItemNoMatch || _s.dropdown.enable === false || this.state.isLoading || this.settings.readonly) return;
       clearTimeout(this.dropdownHide__bindEventsTimeout); // if no value was supplied, show all the "whitelist" items in the dropdown
       // @type [Array] listItems
       // TODO: add a Setting to control items' sort order for "listItems"
@@ -1883,17 +1883,19 @@
         // node isn't in the DOM anynmore because it has been replaced.
 
         if (!this.DOM.scope.contains(editableElm)) return;
-
         var _s = this.settings,
             tagElm = editableElm.closest('.' + _s.classNames.tag),
             textValue = this.input.normalize.call(this, editableElm),
-            originalData = this.tagData(tagElm).__originalData,
+            tagData = this.tagData(tagElm),
+            originalData = tagData.__originalData,
             // pre-edit data
-        hasChanged = this.editTagChangeDetected(this.tagData(tagElm)),
+        hasChanged = this.editTagChangeDetected(tagData),
             isValid = this.validateTag({
-          [_s.tagTextProp]: textValue
+          [_s.tagTextProp]: textValue,
+          __tagId: tagData.__tagId
         }),
-            hasMaxTags,
+            // "__tagId" is needed so validation will skip current tag when checking for dups
+        hasMaxTags,
             newTagData;
 
         if (!textValue) {
@@ -2958,10 +2960,8 @@
     },
 
     setContentEditable(state) {
-      if (!this.settings.readonly && this.settings.userInput) {
-        this.DOM.input.contentEditable = state;
-        this.DOM.input.tabIndex = !!state ? 0 : -1;
-      }
+      this.DOM.input.contentEditable = state;
+      this.DOM.input.tabIndex = !!state ? 0 : -1;
     },
 
     setDisabled(isDisabled) {

diff --git a/dist/tagify.min.js b/dist/tagify.min.js
diff --git a/dist/tagify.polyfills.min.js b/dist/tagify.polyfills.min.js
@@ -1,5 +1,5 @@
 /**
- * Tagify (v 4.13.2) - tags input component
+ * Tagify (v 4.13.3) - tags input component
  * By Yair Even-Or
  * https://github.com/yairEO/tagify
  * Permission is hereby granted, free of charge, to any person obtaining a copy

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@yaireo/tagify",
-    "version": "4.13.2",
+    "version": "4.13.3",
     "homepage": "https://github.com/yairEO/tagify",
     "description": "lightweight, efficient Tags input component in Vanilla JS / React / Angular [super customizable, tiny size & top performance]",
     "keywords": [