Fixed a few white text on white background areas in the chat area of individual issues #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…white text on white background when in an existing issue and adding a new chat comment. On input element focus, text is now black. TODO: when the 'Send' button is clicked and the message is submitted, the input loses focus and goes back to white text on white background. I believe this is due to the 'Send' button being contained within the input-group element along with the input element. So even though the input itself loses focus the input-group still has focus and so it still shows the white background. I don't have time to fix this right now, but it should be fixed in the future.
|
@NortonBW yes, but I've noticed a few other areas where something like this is occuring and was going to take a stab at those in the next few days. May be easier to wait a bit and get them all at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fxed white text on white background in issue message history. Fixed white text on white background when in an existing issue and adding a new chat comment. On input element focus, text is now black. TODO: when the 'Send' button is clicked and the message is submitted, the input loses focus and goes back to white text on white background. I believe this is due to the 'Send' button being contained within the input-group element along with the input element. So even though the input itself loses focus the input-group still has focus and so it still shows the white background. I don't have time to fix this right now, but it should be fixed in the future.