Indexer uses new :bytes-per-chunk option #2820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps limit memory usage when row widths are unpredictable Progress toward xtdb#2816
jarohen
force-pushed
the
2.x
branch
2 times, most recently
from
b226b16
to
c729da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps limit memory usage when row widths are unpredictable.
Progress toward #2816
Experimentation might be useful to try to estimate how closely the limit approximates actual memory usage for the live tree etc, right now it should correlate somewhat but is likely quite inaccurate.
I want to look at using .getBufferSizeFor to get a more accurate estimate, discovered apache/arrow#38242.