-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow class fields with no blank lines between #85
Merged
sindresorhus
merged 1 commit into
xojs:main
from
mondeja:todo-lines-between-class-members
May 6, 2024
Merged
Allow class fields with no blank lines between #85
sindresorhus
merged 1 commit into
xojs:main
from
mondeja:todo-lines-between-class-members
May 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondeja
force-pushed
the
todo-lines-between-class-members
branch
from
May 3, 2024 20:12
155d3de
to
ecd9372
Compare
mondeja
changed the title
Allow class fields without blank lines between
Allow class fields with no blank lines between
May 3, 2024
mondeja
force-pushed
the
todo-lines-between-class-members
branch
from
May 3, 2024 20:13
ecd9372
to
07e3541
Compare
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 20, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 20, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 20, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enforce
option has been added tolines-between-class-members
rule of ESLint in v8.49.0 (see the ESLint changelog). Currently the lowest ESLint version is 8.56.0.