Dereference fix in common copy implementation #461
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the fixes from Clickhouse copy PR - #457 - to the common copy implementation as suggested by @nineinchnick in the discussion there.
As discussed, this PR also extends drivers_test to one more database that uses the common copy (csvq). The extended test failed before the fix and passes after it. This PR also adds a couple of convenience improvements to drivers_test:
Finally, the PR removes the custom Clickhouse copy implementation from #457 since the common copy now includes the same fixes. clickhouse_test.go, extended in #457, still passes.
Closes #427