please accept this pull request ASAP PLEASE! #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change
Apparently during the last few pull requests the capitalization of a few things as well as the "_" character being omitted were made. This prevents it from working. For example...
The class was initially named
INSTRUCTOR_Pooling
In a pull request it was changed to lowercase instead, and that "_" was removed in the same pull request or possibly another, I can't remember.
This pull request corrects the most recent pull request and classes are correctly named throughout the script. Here's a picture of the lines changed:
Second change
I corrected it to use the local path of specified...not sure if this is the PERFECT solution since the
sentence-transformers
library has autil.py
script that does something similar, but THIS WORKS after many hours. Please merge: