Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a higher-order base class #555

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Added a higher-order base class #555

wants to merge 26 commits into from

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Jun 25, 2024

This PR does the following:

  • Adds a HigherOrderNetwork base class for all classes to inherit from. Currently implements a constructor and some basic functionality.
  • Now Hypergraph, SimplicialComplex, and DiHypergraph all inherit from HigherOrderNetwork. SimplicialComplex now no longer inherits from Hypergraph.
  • Methods with warnings (e.g., add_edge) in SimplicialComplex have been removed.
  • Renames the following. These are NOT breaking changes as they are all internal to XGI:
    • Renames _hypergraph to _net_attr
    • Renames _hypergraph_attr_dict_factory to _net_attr_dict_factory
    • Renames _hyperedge_dict_factory to _edge_dict_factory
  • Up-versions pylint.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nwlandry nwlandry marked this pull request as draft June 25, 2024 20:02
@nwlandry nwlandry mentioned this pull request Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (6e5c25b) to head (6bfd5da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   92.55%   92.67%   +0.11%     
==========================================
  Files          59       60       +1     
  Lines        4394     4274     -120     
==========================================
- Hits         4067     3961     -106     
+ Misses        327      313      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant