Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Fix the AOS version tu20190demo and prod-aos #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the AOS version tu20190demo and prod-aos #72

wants to merge 1 commit into from

Conversation

iusyk
Copy link
Contributor

@iusyk iusyk commented Mar 17, 2020

Signed-off-by: Ihor Usyk [email protected]

@iusyk iusyk requested a review from al1img March 17, 2020 20:11
al1img
al1img reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@al1img al1img left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also aos-updatemanager, aos-servicemanage and aos-vis should be fixed in appropriate bbappend.

prod_aos_minimal/aos.xml Outdated Show resolved Hide resolved
@iusyk iusyk force-pushed the fox_aos_version_tu2019_aos branch from daf79d3 to d0cbb92 Compare March 18, 2020 14:17
@iusyk
Copy link
Contributor Author

iusyk commented Mar 18, 2020

Also aos-updatemanager, aos-servicemanage and aos-vis should be fixed in appropriate bbappend.

see xen-troops/meta-xt-prod-tu2019-demo#18

@iusyk iusyk requested review from andr2000, arminn and rshym April 1, 2020 13:58
@rshym
Copy link
Contributor

rshym commented Apr 2, 2020

Please fix commit id of fixed component - seems like it is taken from 'master' branch, but should be from 'thud' branch.

@iusyk iusyk force-pushed the fox_aos_version_tu2019_aos branch from d0cbb92 to b0b6479 Compare April 2, 2020 21:34
@rshym
Copy link
Contributor

rshym commented Apr 6, 2020

It's not clear to me why patch modifies manifests for prod-aos.

@rshym
Copy link
Contributor

rshym commented Apr 6, 2020

Projects "epmd-aepr/img-proprietary" and "xen-troops/meta-xt-agl-base" still have "revision="master". I think this need to be fixed.

@iusyk
Copy link
Contributor Author

iusyk commented Apr 6, 2020

It's not clear to me why patch modifies manifests for prod-aos.

because i has a task to fix aos couple of weeks ago, is it supposed not to change meta-aos in future ?

@iusyk
Copy link
Contributor Author

iusyk commented Apr 6, 2020

eta-xt-agl-base

ok, i do

@rshym
Copy link
Contributor

rshym commented Apr 17, 2020

Please do nothing with this PR for now, due to ongoing development in other projects.

rshym
rshym suggested changes Apr 28, 2020
View reviewed changes
prod_aos/domd.xml
@@ -14,5 +14,5 @@
<project remote="openembedded" name="meta-openembedded" path="meta-openembedded" upstream="thud" revision="4cd3a39f22a2712bfa8fc657d09fe2c7765a4005" />
<project remote="linaro" name="openembedded/meta-linaro" path="meta-linaro" upstream="thud" revision="b30036d4ef7ce9fe746833fc54de6ac7b0e00638" />
<project remote="yoctoproject" name="meta-selinux" path="meta-selinux" upstream="thud" revision="fb6192aa2c5df8e80c5e6d4fa5448d574332f68f" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="thud" revision="thud" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="thud" revision="362ffce00ac19f68dd985d7e145b8c815bcd6991" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this line.
In order to fix prod-aos it's better to follow separate procedure with branches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think not, because the prod is frozen, no changes are supposed to be there.

prod_aos/domf.xml
@@ -11,5 +11,5 @@
<project remote="yoctoproject" name="meta-virtualization" path="meta-virtualization" upstream="thud" revision="9e8c0c96b443828a255e7d6ca6291598347672ac" />
<project remote="yoctoproject" name="poky" path="poky" upstream="thud" revision="e7f0177ef3b6e06b8bc1722fca0241fef08a1530" />
<project remote="openembedded" name="meta-openembedded" path="meta-openembedded" upstream="thud" revision="4cd3a39f22a2712bfa8fc657d09fe2c7765a4005" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="master" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="19f021d6bb5527650b2481caca90982f94ac1a33" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this line.
In order to fix prod-aos it's better to follow separate procedure with branches.

prod_tu2019_demo/domd.xml Outdated
@@ -96,7 +96,7 @@
<project name="foss-for-synopsys-dwc-arc-processors/meta-synopsys" path="bsp/meta-synopsys" remote="github" revision="702a0e826e87796aefa97abc1de0217d3775fd13" upstream="thud-agl"/>

<!-- Xen-troops specific things -->
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="master" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="19f021d6bb5527650b2481caca90982f94ac1a33" />
<project remote="epam" name="epmd-aepr/img-proprietary" path="proprietary" upstream="master" revision="master" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set revision for img-proprietary to ef1aa566d74a11c4d2ae9592474030a706b4cf39

prod_tu2019_demo/domd.xml Outdated
@@ -96,7 +96,7 @@
<project name="foss-for-synopsys-dwc-arc-processors/meta-synopsys" path="bsp/meta-synopsys" remote="github" revision="702a0e826e87796aefa97abc1de0217d3775fd13" upstream="thud-agl"/>

<!-- Xen-troops specific things -->
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="master" />
<project remote="epam" name="epmd-aepr/meta-aos" path="meta-aos" upstream="master" revision="19f021d6bb5527650b2481caca90982f94ac1a33" />
<project remote="epam" name="epmd-aepr/img-proprietary" path="proprietary" upstream="master" revision="master" />
<project remote="github" name="xen-troops/meta-xt-agl-base" path="meta-xt-agl-base" upstream="master" revision="master" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set revision for meta-xt-agl-base to 7c379d746f553ca2c60ddcff464fa8d0aeb6784f

@iusyk iusyk force-pushed the fox_aos_version_tu2019_aos branch from b0b6479 to 53bb6d3 Compare April 6, 2021 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@al1img al1img al1img left review comments

@rshym rshym rshym requested changes

@andr2000 andr2000 Awaiting requested review from andr2000

@arminn arminn Awaiting requested review from arminn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iusyk @rshym @al1img