fix json-compilation-database pch file path bug #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug in json_compilation_database.rb about pch file.
When building a target A, which depends on target B. And the Target B has a prefix header and sets the
precompile prefix header
toYES
. Target A also has its own prefix header, but sets theprecompile prefix header
toNO
.First xcodebuild will build target B, sets the
@pch_path
inJSONCompilationDatabase
viaformat_process_pch_command
, and everything is fine.And then it begins to build target A, since the target A sets the
precompile prefix header
toNO
, theformat_process_pch_command
will not be called, so the@pch_path
remains the same as target B. That's the problem! the target A's pch path will be replaced by Target B's.My solution is simply reset the
@pch_path
before every target informat_build_target
.