[PVR] Timer settings dialog: Fix selection of current channel, … #25186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
phunkyfish
approved these changes
May 10, 2024
…ample on change of client due to selection of another timer type.
ksooo
force-pushed
the
pvr-fix-timer-settings-channel-selection
branch
from
72ce7e3
to
c55e5e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for example on change of client due to selection of another timer type.
If you run a multi-PVR-client setup, and change the timer type from a type from client A to a type provided by client B, then the 'Channel' field of the timer settings dialog was empty afterwards. With this PR, the first valid channel from client B will be selected on timer type change from client A to client B.
Runtime-tested on macOS and Android.
@phunkyfish please review, thanks.