Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kissfft #25180

Merged
merged 1 commit into from
May 12, 2024
Merged

Remove kissfft #25180

merged 1 commit into from
May 12, 2024

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented May 10, 2024

Description

Remove kissfft and its usage

Motivation and context

@neo1973 pointed out in #23808 that this doesnt seem to be used. So nuke it i guess.
Alternative to cleaning up and removing the lib from tree in #23808.

@notspiff pointed me to 2a953d5 where its usage was removed. so dead code it is.

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Looks like its now dead code, once upon a time used for addon vis. Lets pull it out
and see what happens
@fuzzard fuzzard added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: Depends v22 "P" labels May 10, 2024
@fuzzard fuzzard added this to the "P" 22.0 Alpha 1 milestone May 10, 2024
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With surgical precision, 1K lines removed, 1 added. I'm actually disappointed about the 1.

@fuzzard fuzzard merged commit 5f8d504 into xbmc:master May 12, 2024
1 check passed
@fuzzard fuzzard deleted the remove_kissfft branch May 12, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants