Android: Fix generic controllers in UI #25177
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes generic controllers in the UI (and in game) by adding generic keycodes to the Android joystick driver.
PR is:
Note that this only fixes truly "generic" controllers that Android has no buttonmaps for. The particular symptom is that they don't work in either the UI or in game. This doesn't affect generic controllers that work in the UI but not in games.
Motivation and context
Allows generic controllers, that Android doesn't have buttonmaps for, to be mapped in Kodi.
How has this been tested?
Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases
At least one generic controller was reported fixed by this PR (don't have the link).
What is the effect on users?
Types of change