Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix generic controllers in UI #25177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

garbear
Copy link
Member

@garbear garbear commented May 10, 2024

Description

This PR fixes generic controllers in the UI (and in game) by adding generic keycodes to the Android joystick driver.

PR is:

  • Commit 1 - code improvement (also present in #25176)
  • Commit 2 - fix

Note that this only fixes truly "generic" controllers that Android has no buttonmaps for. The particular symptom is that they don't work in either the UI or in game. This doesn't affect generic controllers that work in the UI but not in games.

Motivation and context

Allows generic controllers, that Android doesn't have buttonmaps for, to be mapped in Kodi.

How has this been tested?

Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases

At least one generic controller was reported fixed by this PR (don't have the link).

What is the effect on users?

  • Fixed generic controllers on Android

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

@garbear garbear added this to the "P" 22.0 Alpha 1 milestone May 10, 2024
@garbear garbear changed the title Android: Fix generic controllers Android: Fix generic controllers in UI May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant