Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MinecraftQuery.php #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update MinecraftQuery.php #160

wants to merge 1 commit into from

Conversation

jgniecki
Copy link

Fix parsing for GetBedrockStatus

@jgniecki
Update MinecraftQuery.php
76de361 
Fix parsing for GetBedrockStatus
@xPaw
Copy link
Owner

xPaw commented Apr 30, 2023 •
edited

Is this fixing ; in hostnames? Do you have a server that could be tested against?

This offset idea seems like it will break if any new fields are ever added.

@jgniecki
Copy link
Author

jgniecki commented Apr 30, 2023 •
edited

You are right but I think it's more probable that the ';' sign will appear in hostname field than they will add any new fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jgniecki @xPaw