Merge pull request #54 from wunderio/feature/release-wait

Wait flag for helm release, enables proper post-release creation
wunderio · Jan 22, 2024 · cccef55 · cccef55
2 parents 14ee6e8 + df66a5f
commit cccef55
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/cmd/ciReleaseDeploy.go b/cmd/ciReleaseDeploy.go
@@ -336,11 +336,12 @@ var ciReleaseDeployCmd = &cobra.Command{
 				${EXTRA_DB_USER_PASS} \
 				--values "${SILTA_CONFIG}" \
 				${EXTRA_HELM_FLAGS} \
+				--wait \
 				--timeout "${DEPLOYMENT_TIMEOUT}" &> helm-output.log & pid=$!
 
 				# TODO: Rewrite this part
 
-				echo "Waiting for containers to start"
+				echo "Waiting for containers to start and be ready"
 
 				TIME_WAITING=0
 				LOGS_SHOWN=false
@@ -567,11 +568,12 @@ var ciReleaseDeployCmd = &cobra.Command{
 				--namespace="${NAMESPACE}" \
 				--values "${SILTA_CONFIG}" \
 				${EXTRA_HELM_FLAGS} \
+				--wait \
 				--timeout "${DEPLOYMENT_TIMEOUT}" &> helm-output.log & pid=$!
 
 				# TODO: Rewrite this part
 				
-				echo "Waiting for containers to start"
+				echo "Waiting for containers to start and be ready"
 
 				TIME_WAITING=0
 				LOGS_SHOWN=false

diff --git a/tests/release_test.go b/tests/release_test.go
@@ -222,6 +222,7 @@ func TestReleaseDeployCmd(t *testing.T) {
 				--namespace="${NAMESPACE}" \
 				--values "${SILTA_CONFIG}" \
 				${EXTRA_HELM_FLAGS} \
+				--wait \
 				--timeout "${DEPLOYMENT_TIMEOUT}" &> helm-output.log & pid=$!`
 	CliExecTest(t, command, environment, testString, false)
 
@@ -331,6 +332,7 @@ func TestReleaseDeployCmd(t *testing.T) {
 				--namespace="${NAMESPACE}" \
 				--values "${SILTA_CONFIG}" \
 				${EXTRA_HELM_FLAGS} \
+				--wait \
 				--timeout "${DEPLOYMENT_TIMEOUT}" &> helm-output.log & pid=$!`
 	CliExecTest(t, command, environment, testString, false)