feat: support multiple edfs argument templates #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensneuse
requested changes
Apr 23, 2024
| if lastInputValueTypeRef == -1 { | ||
| return "", fmt.Errorf(`the event subject "%s" defines the final nested input field "%s" in argument template #%d, but it does not exist`, subject, argumentPath[len(argumentPath)-1], templateNumber+1) | ||
| } | ||
| argumentName := argumentPath[0] |
There was a problem hiding this comment.
if len(matches) != 2 {
return "", fmt.Errorf("expected a single matching group for argument template")
}
// the path begins with ".", so ignore the first empty string element
argumentPath := strings.Split(matches[1][1:], ".")
We only have a match if the regex matches, which must be [a-zA-Z0-9_] after a period, which means we should be guaranteed to have at least one item in the argument path. If we don't, the regex didn't match, so we'd never get there.
Either way, this tells me that some regex tests would be useful. I'll add them.
devsergiy
requested changes
Apr 23, 2024
| if len(matches) != 1 || len(matches[0]) != 2 { | ||
| return "", fmt.Errorf("expected subject to match regex") | ||
| func (p *Planner[T]) inputObjectDefinitionRefByFieldDefinitionRef(fieldDefinitionRef int, argumentNameBytes []byte) (inputObjectDefinitionRef int, inputValueTypeRef int) { | ||
| inputValueTypeRef = -1 |
There was a problem hiding this comment.
Could you use here and below ast.InvalidRef instead of -1 literal
StarpTech
reviewed
May 17, 2024
| Path: []string{string(variableName)}, | ||
| Renderer: renderer, | ||
| // substitute the variable templates for dummy values to check that the string is a valid NATS subject | ||
| if natsserver.IsValidSubject(variableTemplateRegex.ReplaceAllLiteralString(substitutedSubject, "a")) { |
There was a problem hiding this comment.
Can we abstract it in a way that we don't get provider specific in the pubsub implementation? For Kafka, topics should be immutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.