Skip to content

Commit

Permalink
Restore install_additional_packages.yml include
Browse files Browse the repository at this point in the history
Regression caused by #10

Fixes #14
  • Loading branch information
wtanaka committed Apr 9, 2019
1 parent bb73872 commit 3377fb0
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 2 deletions.
1 change: 1 addition & 0 deletions tasks/become.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
- { become: yes, include: Debian.yml, when: ansible_os_family == 'Debian' }
- { become: yes, include: RedHat.yml, when: ansible_os_family == 'RedHat' }
- { become: yes, include: install_package_names.yml }
- { become: yes, include: install_additional_packages.yml }
2 changes: 0 additions & 2 deletions tasks/install_additional_packages.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
- name: install {{gcloud_sdk_additional_package_names | join(' ')}} with default package manager
action: "{{backcompat_pkg_mgr}} name={{item}}"
sudo: yes
register: result_install_additional
until: result_install_additional|success
# Workaround https://github.com/ansible/ansible/issues/16868 and
Expand All @@ -24,7 +23,6 @@
# Use command since dnf was only added as a module in ansible 1.9.0
- name: install {{gcloud_sdk_additional_package_names | join (' ')}} with dnf
command: dnf install -y {{gcloud_sdk_additional_package_names | join(' ')}}
sudo: yes
register: result_install_additional_dnf
until: result_install_additional_dnf|success
# Workaround https://github.com/ansible/ansible/issues/16868 and
Expand Down
36 changes: 36 additions & 0 deletions tasks/install_additional_packages_sudo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
- name: install {{gcloud_sdk_additional_package_names | join(' ')}} with default package manager
action: "{{backcompat_pkg_mgr}} name={{item}}"
sudo: yes
register: result_install_additional
until: result_install_additional|success
# Workaround https://github.com/ansible/ansible/issues/16868 and
# increase default retry count
retries: 20
delay: 10
when: >
gcloud_sdk_additional_package_names is defined and
(backcompat_pkg_mgr == "yum" or backcompat_pkg_mgr == "apt")
with_items: "{{ gcloud_sdk_additional_package_names }}"

# Handle dnf case for Fedora
- name: "check if {{gcloud_sdk_additional_package_names | join(' ')}} exists"
command: "rpm -q {{gcloud_sdk_additional_package_names | join(' ')}}"
changed_when: False
ignore_errors: True
register: package_exists_result
when: gcloud_sdk_additional_package_names is defined and backcompat_pkg_mgr == "dnf"

# Use command since dnf was only added as a module in ansible 1.9.0
- name: install {{gcloud_sdk_additional_package_names | join (' ')}} with dnf
command: dnf install -y {{gcloud_sdk_additional_package_names | join(' ')}}
sudo: yes
register: result_install_additional_dnf
until: result_install_additional_dnf|success
# Workaround https://github.com/ansible/ansible/issues/16868 and
# increase default retry count
retries: 20
delay: 10
when: >
gcloud_sdk_additional_package_names is defined and backcompat_pkg_mgr == "dnf" and
package_exists_result|failed
1 change: 1 addition & 0 deletions tasks/sudo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
- include: RedHat_sudo.yml
when: ansible_os_family == 'RedHat'
- include: install_package_names_sudo.yml
- include: install_additional_packages_sudo.yml

0 comments on commit 3377fb0

Please sign in to comment.