Adds compose v2 and v1 support #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit an outstanding Pull Req from original repo
Create the input to do a conditional later
ashihadeh-boku
suggested changes
Nov 21, 2021
| @@ -15,7 +15,7 @@ jobs: | |||
| with: | |||
| fetch-depth: 1 | |||
| - name: Start Deployment | |||
| uses: wshihadeh/docker-deployment-action@master | |||
| uses: gonzalochief/docker-deployment-action@master | |||
There was a problem hiding this comment.
can you please reset this and push it again?
| @@ -29,7 +29,7 @@ jobs: | |||
| args: -p test up -d | |||
|
|
|||
| - name: Start Deployment without copy | |||
| uses: wshihadeh/docker-deployment-action@master | |||
| uses: gonzalochief/docker-deployment-action@master | |||
Comment on lines
+61
to
+69
| if [ "$INPUT_DEPLOYMENT_MODE" == "docker-compose" ] && [ "$INPUT_DOCKER_COMPOSE_VER" == "v2" ]; then | ||
| DOCKER_COMP_COMMAND="docker compose" | ||
| elif [ "$INPUT_DEPLOYMENT_MODE" == "docker-compose" ] && [ "$INPUT_DOCKER_COMPOSE_VER" == "v1" ]; then | ||
| DOCKER_COMP_COMMAND="docker-compose" | ||
| else | ||
| DOCKER_COMP_COMMAND="docker compose" | ||
| fi | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| if [ "$INPUT_DEPLOYMENT_MODE" == "docker-compose" ] && [ "$INPUT_DOCKER_COMPOSE_VER" == "v2" ]; then | |
| DOCKER_COMP_COMMAND="docker compose" | |
| elif [ "$INPUT_DEPLOYMENT_MODE" == "docker-compose" ] && [ "$INPUT_DOCKER_COMPOSE_VER" == "v1" ]; then | |
| DOCKER_COMP_COMMAND="docker-compose" | |
| else | |
| DOCKER_COMP_COMMAND="docker compose" | |
| fi | |
| DOCKER_COMP_COMMAND="docker compose" | |
| if [ "$INPUT_DEPLOYMENT_MODE" == "docker-compose" ] && [ "$INPUT_DOCKER_COMPOSE_VER" == "v1" ]; then | |
| DOCKER_COMP_COMMAND="docker-compose" | |
| fi |
|
can you reset the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reject the changes to the main.yaml file. Those changes do not affect the functionality. the change was made for testing purposes.
the rest is OK and tested.