Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python exclusions to gitignore #710

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daltzctr
Copy link

No description provided.

@ThadHouse
Copy link
Member

There are too many raw file blocks in here. Do all of these file types get put in the root?

@daltzctr
Copy link
Author

It's mostly pulled from the github python template gitignore. The only ones I've noticed locally are __pycache__ and venv

@ThadHouse
Copy link
Member

Yeah we'd want to limit this to folders. Raw blocking file types is incorrect, because other projects might need those.

@daltzctr
Copy link
Author

@ThadHouse I've minimized to just what I think is necessary for Python

@sciencewhiz
Copy link
Contributor

Under what conditions would these python files end up in a gradle wpi project?

@daltzctr
Copy link
Author

It doesn't currently but all robotpy init does is add a robot.py and pyproject.toml, but given #622 I would expect VS Code to create Python projects.

Additionally, robotpy init doesn't have a gitignore either, which requires users to create their own. Using the wpilib project gitignore seems like a good start.

@sciencewhiz
Copy link
Contributor

I think that robotpy init making a .gitignore would be better then copying a C++/Java .gitignore. And even if it was implemented in the vs-code extension, I think it would be a different .gitignore, rather then adding onto the C++/Java one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants