Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixing null/undefined theme argument for the WordPressBlocksProvider #2013

Draft
wants to merge 6 commits into
base: canary
Choose a base branch
from

Conversation

colinmurphy
Copy link
Contributor

@colinmurphy colinmurphy commented Dec 20, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Fixing an issue with the WordPressBlocksProvider that doesn't allow the theme argument to be null.

Related Issue(s):

#1986

Testing

I have tested this on 2 different ways

  1. Using this current repo and the next/example block support
  2. Setting up Faust using this branch
  3. Coping changes into a current Faust setup

Screenshots

Screenshot 2024-12-20 at 15 17 11

Documentation Changes

Dependant PRs

@colinmurphy colinmurphy self-assigned this Dec 20, 2024
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: d7146e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colinmurphy colinmurphy changed the title Issue #1986 - Fixing null/undefined theme argument for the WordPressBlocksProvider Issue 1986 - Fixing null/undefined theme argument for the WordPressBlocksProvider Dec 20, 2024
@colinmurphy colinmurphy changed the title Issue 1986 - Fixing null/undefined theme argument for the WordPressBlocksProvider Fixing null/undefined theme argument for the WordPressBlocksProvider Dec 20, 2024
@colinmurphy colinmurphy changed the title Fixing null/undefined theme argument for the WordPressBlocksProvider Bug: Fixing null/undefined theme argument for the WordPressBlocksProvider Dec 20, 2024
@colinmurphy colinmurphy changed the title Bug: Fixing null/undefined theme argument for the WordPressBlocksProvider Bug: Fixing null/undefined theme argument for the WordPressBlocksProvider Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@colinmurphy
Copy link
Contributor Author

@moonmeister Can you review this please and see if you can still replicate issue #1986 please

@colinmurphy
Copy link
Contributor Author

@moonmeister I need to update this PR as some of the logic isn't correct

@colinmurphy
Copy link
Contributor Author

@moonmeister This is ready for review.

@moonmeister
Copy link
Collaborator

Can you explain why/how this fixes the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants