Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update block-support-example docs #2008

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

colinmurphy
Copy link
Contributor

@colinmurphy colinmurphy commented Dec 12, 2024

Tasks

  • [] I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Issue when running block-support example with a 500 HTTP status error.

After debugging the issue with enabling logging for the operations.query I found Type loader is expected to return a callable or valid type "CreateBlockBlockB

However I missed on crucial step which was to run npm run blockset to install the block in WordPress.

I have now updated the README for block-support-example

Related Issue(s):

Testing

  1. Setup latest WP with Local and latest WP GraphQL, Faust and content blocks
  2. Cloned the latest canaray branch for faust
  3. Ran Faust from the block-support directory after adding an .env.local
  4. See screeenshots below

Screenshots

image image

Documentation Changes

Dependant PRs

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 537eca6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2024

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@colinmurphy colinmurphy marked this pull request as ready for review December 12, 2024 12:54
@colinmurphy colinmurphy requested a review from a team as a code owner December 12, 2024 12:54
@colinmurphy
Copy link
Contributor Author

After talking to @theodesp this isn't a bug but a missing step in the documentation

I need to run npm run blockset which should add this block into WordPress - https://github.com/wpengine/faustjs/blob/canary/examples/next/block-support/wp-blocks/block-b/block.json

Verifying process locally and I will update the PR to include in the README documentation.

@colinmurphy colinmurphy changed the title Bug: Fixed example block support Feat: Update block-support-example docs Dec 12, 2024

```.env.local
# Your WordPress site URL
NEXT_PUBLIC_WORDPRESS_URL=https://bpheadlessb559.wpenginepowered.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated link and also preview link for Faust.
@colinmurphy colinmurphy merged commit 32c8cf7 into canary Dec 17, 2024
4 checks passed
@colinmurphy colinmurphy deleted the bug/block-support-missing-blockb-type branch December 17, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants