Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string #7059

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #7042
Fixed error for some users when updating from one version to another.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check #7042

Technical description

Revert the phpstan update on the method.

Documentation

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal self-assigned this Oct 25, 2024
@Khadreal Khadreal requested a review from a team October 25, 2024 09:57
@Khadreal Khadreal added the type: bug Indicates an unexpected problem or unintended behavior label Oct 25, 2024
Copy link

codacy-production bot commented Oct 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c2e65f01 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c2e65f0) Report Missing Report Missing Report Missing
Head commit (37e9f6c) 0 0 0.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7059) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

inc/Engine/Plugin/UpdaterSubscriber.php Outdated Show resolved Hide resolved
@Miraeld Miraeld self-requested a review October 25, 2024 12:17
@Khadreal Khadreal changed the title Fixes #7042 Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string Oct 25, 2024
@Mai-Saad
Copy link
Contributor

For test: reproduce the issue and confirm it's fixed is enough. Please check this for reproducing it https://wp-media.slack.com/archives/CUT7FLHF1/p1730103718060409?thread_ts=1730101320.378249&cid=CUT7FLHF1

@Khadreal Khadreal requested a review from a team November 1, 2024 16:08
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Khadreal, for this PR.
Reproduced error outside the PR by using snippet from thread. On PR this error no longer happens (just some deprecation notices because of snippet but confirmed with devs that those are expected in this situation, and a very edgy one).
Confirming this as fixed on test env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string
5 participants