-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string #7059
base: develop
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
For test: reproduce the issue and confirm it's fixed is enough. Please check this for reproducing it https://wp-media.slack.com/archives/CUT7FLHF1/p1730103718060409?thread_ts=1730101320.378249&cid=CUT7FLHF1 |
e1fa3eb
to
37e9f6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Khadreal, for this PR.
Reproduced error outside the PR by using snippet from thread. On PR this error no longer happens (just some deprecation notices because of snippet but confirmed with devs that those are expected in this situation, and a very edgy one).
Confirming this as fixed on test env.
Description
Fixes #7042
Fixed error for some users when updating from one version to another.
Type of change
Detailed scenario
Check #7042
Technical description
Revert the phpstan update on the method.
Documentation
Mandatory Checklist
Code validation
Code style